To start, I am a tall guy (6'5") and often have a difficult time finding clothes that fit off the shelf. I was looking for a new pair of trunks that were a bit more fitted and not as long as the typical board shorts. I looked everywhere to find these locally so I could try them on, but was unsuccessful.
These are perfect though - fit great in the waist and they're absolutely perfect length - just what I was looking for. At 220lbs, a 36" was perfect. If you're stuck between sizes 34 and 36, I'd probably recommend sizing up. I wear between 34 and 36 in other clothes depending on brand/cut, and these shorts in 36 fit to perfection.
The built-in pockets make these great for everyday wear even if you're not going to be in the water. Great fit, quality feel, awesome looks. Buy these - you won't be disappointed.